Delete the branch_list_keyset_pagination feature flag

This feature flag was introduced in 13.2, which is more than 12 milestones ago.

As part of our process we want to ensure feature flags don't stay too long in the codebase.

Rollout issue: #369435

Remaining mentions of the feature flag (click to expand)

spec/lib/gitlab/pagination/gitaly_keyset_pager_spec.rb
45:        stub_feature_flags(branch_list_keyset_pagination: false)
66:        stub_feature_flags(branch_list_keyset_pagination: project)

spec/requests/api/branches_spec.rb
20:    stub_feature_flags(branch_list_keyset_pagination: false)
104:          stub_feature_flags(branch_list_keyset_pagination: project)

spec/services/projects/branches_by_mode_service_spec.rb
61:        stub_feature_flags(branch_list_keyset_pagination: false)

app/services/projects/branches_by_mode_service.rb
40:    Feature.enabled?(:branch_list_keyset_pagination, project)

app/views/projects/branches/index.html.haml
58:  - if Feature.enabled?(:branch_list_keyset_pagination, @project)

config/feature_flags/development/branch_list_keyset_pagination.yml
2:name: branch_list_keyset_pagination

lib/gitlab/pagination/gitaly_keyset_pager.rb
40:          Feature.enabled?(:branch_list_keyset_pagination, project)
53:          Feature.enabled?(:branch_list_keyset_pagination, project)

spec/lib/gitlab/pagination/gitaly_keyset_pager_spec.rb
43:    context 'with branch_list_keyset_pagination feature off' do
45:        stub_feature_flags(branch_list_keyset_pagination: false)
59:    context 'with branch_list_keyset_pagination feature on' do
66:        stub_feature_flags(branch_list_keyset_pagination: project)

spec/requests/api/branches_spec.rb
20:    stub_feature_flags(branch_list_keyset_pagination: false)
41:      context 'with branch_list_keyset_pagination feature off' do
102:      context 'with branch_list_keyset_pagination feature on' do
104:          stub_feature_flags(branch_list_keyset_pagination: project)

spec/services/projects/branches_by_mode_service_spec.rb
59:    context 'branch_list_keyset_pagination is disabled' do
61:        stub_feature_flags(branch_list_keyset_pagination: false)

Currently the feature flag is disabled on production

It is possible that this MR will still need some changes to remove references to the feature flag in the code. At the moment the gitlab-housekeeper is not always capable of removing all references so you must check the diff and pipeline failures to confirm if there are any issues. It is the responsibility of groupsource code to push those changes to this branch.

Note: If you do not want to remove this feature flag at this time, you can add an intended_to_rollout_by_date attribute in the feature flag YAML file to prevent automated removal.

TODO for the reviewers before merging this MR

• See the status of the rollout by checking #369435, https://gitlab.com/gitlab-com/gl-infra/feature-flag-log/-/issues/?search=branch_list_keyset_pagination&sort=created_date&state=all&label_name%5B%5D=host%3A%3Agitlab.com
• Verify the feature flag status via chatops by running /chatops run feature get branch_list_keyset_pagination.
• Search for references to BranchListKeysetPagination in frontend part of code
• Search for references to branch_list_keyset_pagination in code
• Check if we need to remove any Gem or other related code by looking at the changes in !35819 (merged)

This change was generated by gitlab-housekeeper in CI using the Keeps::DeleteOldFeatureFlags keep.

To provide feedback on your experience with gitlab-housekeeper please create an issue with the label GitLab Housekeeper and consider pinging the author of this keep.