[go: up one dir, main page]
Skip to content

Delete the enable_add_on_users_filtering feature flag

Project token used in gitlab-org/quality/engineering-productivity/team/-/settings/ci_cd as `HOUSEKEEPER_GITLAB_API_TOKEN`requested to merge
delete-old-feature-flags-enable_add_on_users_filtering into master

This feature flag was introduced in 16.7, which is more than 4 milestones ago.

As part of our process we want to ensure feature flags don't stay too long in the codebase.

Rollout issue: https://gitlab.com/gitlab-org/gitlab/-/issues/431365

Remaining mentions of the feature flag (click to expand) 
ee/app/controllers/admin/gitlab_duo/seat_utilization_controller.rb
18:        push_frontend_feature_flag(:enable_add_on_users_filtering)

ee/app/controllers/admin/gitlab_duo_controller.rb
16:      push_frontend_feature_flag(:enable_add_on_users_filtering)

ee/app/controllers/ee/groups/usage_quotas_controller.rb
17:          push_frontend_feature_flag(:enable_add_on_users_filtering, group)

ee/app/controllers/groups/settings/gitlab_duo/seat_utilization_controller.rb
16:          push_frontend_feature_flag(:enable_add_on_users_filtering, group)

ee/spec/requests/groups/usage_quotas_spec.rb
46:        stub_feature_flags(enable_add_on_users_filtering: false)

ee/app/controllers/admin/gitlab_duo/seat_utilization_controller.rb
18:        push_frontend_feature_flag(:enable_add_on_users_filtering)

ee/app/controllers/admin/gitlab_duo_controller.rb
16:      push_frontend_feature_flag(:enable_add_on_users_filtering)

ee/app/controllers/ee/groups/usage_quotas_controller.rb
17:          push_frontend_feature_flag(:enable_add_on_users_filtering, group)

ee/app/controllers/groups/settings/gitlab_duo/seat_utilization_controller.rb
16:          push_frontend_feature_flag(:enable_add_on_users_filtering, group)

ee/app/assets/javascripts/usage_quotas/code_suggestions/components/add_on_eligible_user_list.vue
143:      return this.glFeatures.enableAddOnUsersFiltering;

ee/app/assets/javascripts/usage_quotas/code_suggestions/components/saas_add_on_eligible_user_list.vue
129:      return this.glFeatures.enableAddOnUsersFiltering;

ee/app/assets/javascripts/usage_quotas/code_suggestions/components/self_managed_add_on_eligible_user_list.vue
79:      return this.glFeatures.enableAddOnUsersFiltering;

ee/app/assets/javascripts/usage_quotas/code_suggestions/components/add_on_eligible_user_list.vue
143:      return this.glFeatures.enableAddOnUsersFiltering;

ee/app/assets/javascripts/usage_quotas/code_suggestions/components/saas_add_on_eligible_user_list.vue
129:      return this.glFeatures.enableAddOnUsersFiltering;

ee/app/assets/javascripts/usage_quotas/code_suggestions/components/self_managed_add_on_eligible_user_list.vue
79:      return this.glFeatures.enableAddOnUsersFiltering;

ee/spec/frontend/usage_quotas/code_suggestions/components/add_on_eligible_user_list_spec.js
178:    enableAddOnUsersFiltering = false,
207:            enableAddOnUsersFiltering,
432:    describe('with enableAddOnUsersFiltering enabled', () => {
434:        return createComponent({ enableAddOnUsersFiltering: true });
451:            enableAddOnUsersFiltering: true,
539:    describe('with enableAddOnUsersFiltering and isBulkAddOnAssignmentEnabled enabled', () => {
542:          enableAddOnUsersFiltering: true,
562:            enableAddOnUsersFiltering: true,

ee/spec/frontend/usage_quotas/code_suggestions/components/saas_add_on_eligible_user_list_spec.js
36:  let enableAddOnUsersFiltering = false;
118:          enableAddOnUsersFiltering,
193:    describe('when enableAddOnUsersFiltering is enabled', () => {
195:        enableAddOnUsersFiltering = true;

ee/spec/frontend/usage_quotas/code_suggestions/components/self_mananged_add_on_eligible_user_list_spec.js
35:  let enableAddOnUsersFiltering = false;
94:          enableAddOnUsersFiltering,
132:    describe('when enableAddOnUsersFiltering is enabled', () => {
134:        enableAddOnUsersFiltering = true;

ee/spec/requests/groups/usage_quotas_spec.rb
40:        expect(response.body).to have_pushed_frontend_feature_flags(enableAddOnUsersFiltering: true)
52:        expect(response.body).not_to have_pushed_frontend_feature_flags(enableAddOnUsersFiltering: true)

CHANGELOG.md
7661:- [Enable FF enable_add_on_users_filtering by default](https://gitlab.com/gitlab-org/gitlab/-/commit/87a1593e1623b680ab3ce165ce810f03a1b335e3) ([merge request](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/168692))

config/feature_flags/development/enable_add_on_users_filtering.yml
2:name: enable_add_on_users_filtering

ee/app/controllers/admin/gitlab_duo/seat_utilization_controller.rb
18:        push_frontend_feature_flag(:enable_add_on_users_filtering)

ee/app/controllers/admin/gitlab_duo_controller.rb
16:      push_frontend_feature_flag(:enable_add_on_users_filtering)

ee/app/controllers/ee/groups/usage_quotas_controller.rb
17:          push_frontend_feature_flag(:enable_add_on_users_filtering, group)

ee/app/controllers/groups/settings/gitlab_duo/seat_utilization_controller.rb
16:          push_frontend_feature_flag(:enable_add_on_users_filtering, group)

ee/spec/requests/groups/usage_quotas_spec.rb
36:    context 'with enable_add_on_users_filtering enabled' do
44:    context 'with enable_add_on_users_filtering disabled' do
46:        stub_feature_flags(enable_add_on_users_filtering: false)

Currently the feature flag is enabled on production

It is possible that this MR will still need some changes to remove references to the feature flag in the code. At the moment the gitlab-housekeeper is not always capable of removing all references so you must check the diff and pipeline failures to confirm if there are any issues. It is the responsibility of groupprovision to push those changes to this branch.

Note: If you do not want to remove this feature flag at this time, you can add an intended_to_rollout_by_date attribute in the feature flag YAML file to prevent automated removal.

TODO for the reviewers before merging this MR

This change was generated by gitlab-housekeeper using the Keeps::DeleteOldFeatureFlags keep.

To provide feedback on your experience with gitlab-housekeeper please create an issue with the label GitLab Housekeeper and consider pinging the author of this keep.

Merge request reports