Delete the `glql_integration` feature flag (!196962) · Merge requests · GitLab.org / GitLab

This feature flag was introduced in 17.3, which is more than 4 milestones ago.

As part of our process we want to ensure feature flags don't stay too long in the codebase.

Remaining mentions of the feature flag (click to expand)

app/controllers/concerns/wiki_actions.rb
38:      push_force_frontend_feature_flag(:glql_integration, !!container&.glql_integration_feature_flag_enabled?)

app/controllers/groups/boards_controller.rb
13:    push_force_frontend_feature_flag(:glql_integration, !!group&.glql_integration_feature_flag_enabled?)

app/controllers/groups/work_items_controller.rb
14:      push_force_frontend_feature_flag(:glql_integration, !!group&.glql_integration_feature_flag_enabled?)

app/controllers/projects/boards_controller.rb
13:    push_force_frontend_feature_flag(:glql_integration, !!project&.glql_integration_feature_flag_enabled?)

app/controllers/projects/issues_controller.rb
57:    push_force_frontend_feature_flag(:glql_integration, !!project&.glql_integration_feature_flag_enabled?)

app/controllers/projects/merge_requests/application_controller.rb
11:    push_force_frontend_feature_flag(:glql_integration, !!project&.glql_integration_feature_flag_enabled?)

app/controllers/projects/work_items_controller.rb
15:    push_force_frontend_feature_flag(:glql_integration, !!project&.glql_integration_feature_flag_enabled?)

app/models/group.rb
1114:    feature_flag_enabled_for_self_or_ancestor?(:glql_integration)

app/models/project.rb
3460:    group&.glql_integration_feature_flag_enabled? || Feature.enabled?(:glql_integration, self)

doc/user/glql/_index.md
18:- [Introduced](https://gitlab.com/groups/gitlab-org/-/epics/14767) in GitLab 17.4 [with a flag](../../administration/feature_flags/_index.md) named `glql_integration`. Disabled by default.

doc/user/glql/fields.md
18:- [Introduced](https://gitlab.com/groups/gitlab-org/-/epics/14767) in GitLab 17.4 [with a flag](../../administration/feature_flags/_index.md) named `glql_integration`. Disabled by default.

doc/user/glql/functions.md
18:- [Introduced](https://gitlab.com/groups/gitlab-org/-/epics/14767) in GitLab 17.4 [with a flag](../../administration/feature_flags/_index.md) named `glql_integration`. Disabled by default.

ee/app/controllers/groups/epics_controller.rb
24:    push_force_frontend_feature_flag(:glql_integration, !!@group&.glql_integration_feature_flag_enabled?)

spec/models/group_spec.rb
4367:      let(:feature_flag) { :glql_integration }
4368:      let(:feature_flag_method) { :glql_integration_feature_flag_enabled? }

spec/models/project_spec.rb
9445:      let(:feature_flag_method) { :glql_integration_feature_flag_enabled? }
9446:      let(:feature_flag) { :glql_integration }

app/assets/javascripts/behaviors/markdown/render_gfm.js
55:  if (gon?.features?.glqlIntegration) renderGlql(glqlEls.map((e) => e.parentNode));

spec/frontend/behaviors/markdown/render_gfm_spec.js
32:        gon.features = { glqlIntegration: true };
44:        gon.features = { glqlIntegration: false };

app/assets/javascripts/behaviors/markdown/render_gfm.js
55:  if (gon?.features?.glqlIntegration) renderGlql(glqlEls.map((e) => e.parentNode));

spec/frontend/behaviors/markdown/render_gfm_spec.js
30:    describe('when glqlIntegration is enabled', () => {
32:        gon.features = { glqlIntegration: true };
42:    describe('when glqlIntegration is disabled', () => {
44:        gon.features = { glqlIntegration: false };

app/controllers/concerns/wiki_actions.rb
38:      push_force_frontend_feature_flag(:glql_integration, !!container&.glql_integration_feature_flag_enabled?)

app/controllers/groups/boards_controller.rb
13:    push_force_frontend_feature_flag(:glql_integration, !!group&.glql_integration_feature_flag_enabled?)

app/controllers/groups/work_items_controller.rb
14:      push_force_frontend_feature_flag(:glql_integration, !!group&.glql_integration_feature_flag_enabled?)

app/controllers/projects/boards_controller.rb
13:    push_force_frontend_feature_flag(:glql_integration, !!project&.glql_integration_feature_flag_enabled?)

app/controllers/projects/issues_controller.rb
57:    push_force_frontend_feature_flag(:glql_integration, !!project&.glql_integration_feature_flag_enabled?)

app/controllers/projects/merge_requests/application_controller.rb
11:    push_force_frontend_feature_flag(:glql_integration, !!project&.glql_integration_feature_flag_enabled?)

app/controllers/projects/work_items_controller.rb
15:    push_force_frontend_feature_flag(:glql_integration, !!project&.glql_integration_feature_flag_enabled?)

app/models/group.rb
1113:  def glql_integration_feature_flag_enabled?
1114:    feature_flag_enabled_for_self_or_ancestor?(:glql_integration)

app/models/project.rb
3459:  def glql_integration_feature_flag_enabled?
3460:    group&.glql_integration_feature_flag_enabled? || Feature.enabled?(:glql_integration, self)

config/feature_flags/development/glql_integration.yml
2:name: glql_integration

doc/user/glql/_index.md
18:- [Introduced](https://gitlab.com/groups/gitlab-org/-/epics/14767) in GitLab 17.4 [with a flag](../../administration/feature_flags/_index.md) named `glql_integration`. Disabled by default.

doc/user/glql/fields.md
18:- [Introduced](https://gitlab.com/groups/gitlab-org/-/epics/14767) in GitLab 17.4 [with a flag](../../administration/feature_flags/_index.md) named `glql_integration`. Disabled by default.

doc/user/glql/functions.md
18:- [Introduced](https://gitlab.com/groups/gitlab-org/-/epics/14767) in GitLab 17.4 [with a flag](../../administration/feature_flags/_index.md) named `glql_integration`. Disabled by default.

ee/app/controllers/groups/epics_controller.rb
24:    push_force_frontend_feature_flag(:glql_integration, !!@group&.glql_integration_feature_flag_enabled?)

spec/models/group_spec.rb
4365:  describe '#glql_integration_feature_flag_enabled?' do
4367:      let(:feature_flag) { :glql_integration }
4368:      let(:feature_flag_method) { :glql_integration_feature_flag_enabled? }

spec/models/project_spec.rb
9441:  describe '#glql_integration_feature_flag_enabled?' do
9445:      let(:feature_flag_method) { :glql_integration_feature_flag_enabled? }
9446:      let(:feature_flag) { :glql_integration }

Currently the feature flag is enabled on production

It is possible that this MR will still need some changes to remove references to the feature flag in the code. At the moment the gitlab-housekeeper is not always capable of removing all references so you must check the diff and pipeline failures to confirm if there are any issues. It is the responsibility of groupknowledge to push those changes to this branch.

Note: If you do not want to remove this feature flag at this time, you can add an intended_to_rollout_by_date attribute in the feature flag YAML file to prevent automated removal.

TODO for the reviewers before merging this MR

See the status of the rollout by checking #476990 (closed), https://gitlab.com/gitlab-com/gl-infra/feature-flag-log/-/issues/?search=glql_integration&sort=created_date&state=all&label_name%5B%5D=host%3A%3Agitlab.com
Verify the feature flag status via chatops by running /chatops run feature get glql_integration.
Search for references to GlqlIntegration in frontend part of code
Search for references to glql_integration in code
Check if we need to remove any Gem or other related code by looking at the changes in !161942 (merged)

This change was generated by gitlab-housekeeper using the Keeps::DeleteOldFeatureFlags keep.

To provide feedback on your experience with gitlab-housekeeper please create an issue with the label GitLab Housekeeper and consider pinging the author of this keep.

Delete the glql_integration feature flag

TODO for the reviewers before merging this MR

Merge request reports

Delete the `glql_integration` feature flag