Fix bug in fix suggestion
What does this MR do and why?
When initially setting this up with client resolvers I thought that the control ID had the data for what is actually the control name. Once the client resolvers were switched out, this broke the fix suggestion section. This commit switches the ID for the name so that the fix suggestion works.
References
Related to #541093 (closed)
Screenshots
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
- You need to have a group with Ultimate license.
- Ensure the feature flag is enabled:
echo "Feature.enable(:compliance_violations_report)" | gdk rails console
- Required data, you can do either of following steps:
- You can checkout branch
hraghuvanshi-comp-violations-seeder
and run commandFILTER=compliance_report_data SEED_COMPLIANCE_REPORT_DATA=1 GROUPID=<group_id> bundle exec rake db:seed_fu
for filling required data and you can run query. - Create all items manually:
-
You need to have at least one project under the group, atleast one audit event related to the project.
-
Also, have at least one compliance framework in the group, the framework should have atleast one compliance control.
-
The framework should be applied to the project.
-
Now create a compliance violation entry in the database by running following command in the rails console:
ComplianceManagement::Projects::ComplianceViolation.create(project_id: <project_id>, namespace_id: <namespace_id>, audit_event_id: <audit_event_id>, compliance_requirements_control_id: <compliance_requirements_control_id>, status: 0, audit_event_table_name: 0)
-
- You can checkout branch
- Navigate to the project that now has the violation, and go to
path/to/project/-/security/compliance_violations/<violation-id>
- Validate that the drawer works as expected
MR acceptance checklist
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.