[go: up one dir, main page]

Skip to content

Reduce cached SQL queries in /api/v4/internal/pages endpoint

What does this MR do and why?

Previously VirtualDomain#pages_access_control_trie dominated the CPU profile because the memoization was not working properly. It was being memoized with the value of self_and_descendants, which is a different object ID each time the method is called. Fix this by memoizing pages_access_control_trie directly.

References

Relates to gitlab-com/gl-infra/production#20759

How to set up and validate locally

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Stan Hu

Merge request reports

Loading