[Vice-emu-commit] SF.net SVN: vice-emu: [18750] trunk/vice/src/romset.c

Revision: 18750
          http://vice-emu.svn.sourceforge.net/vice-emu/?rev=18750&view=rev
Author:   strik
Date:     2008-04-27 11:02:48 -0700 (Sun, 27 Apr 2008)

Log Message:
-----------
2008-04-27  Spiro Trikaliotis  <spi...@gm...>

	* romset.c: romset_archive_save() opens the VRA file to write in
	binary mode, as the contents written already contain the "right"
	delimiters for the platform!

Modified Paths:
--------------
    trunk/vice/src/romset.c

Modified: trunk/vice/src/romset.c
===================================================================
--- trunk/vice/src/romset.c	2008-04-27 16:33:36 UTC (rev 18749)
+++ trunk/vice/src/romset.c	2008-04-27 18:02:48 UTC (rev 18750)
@@ -350,7 +350,17 @@
 
     newname = util_add_extension_const(filename, "vra");
 
-    if ((fp = fopen(newname, MODE_WRITE_TEXT)) == NULL) {
+    /*
+     * spiro-20080427:
+     * The fopen() is *not* performed with MODE_WRITE_TEXT, but with
+     * MODE_WRITE (binary), as the list already contains the
+     * platform-specific delimiters! Compare romset_archive_list()
+     * below!
+     * Otherwise, the .vra file would contain too many delimiters,
+     * as it was the case with WinVICE 1.22.
+     */
+
+    if ((fp = fopen(newname, MODE_WRITE)) == NULL) {
         log_warning(romset_log,
                     "Could not open file '%s' for writing!", newname);
         lib_free(newname);


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.