Re: [liblo] Part of curly braces command omitted

Hi,

I believe this is now fixed (and unit tested!) on master, along with a
couple of other fixes to the pattern matcher. Thanks very much for
pointing out this problem.  Can you let me know if it seems fixed to
you?

regards,
Steve

On Wed, Apr 10, 2019 at 12:36 AM Stephen Sinclair <rad...@gm...> wrote:
>
> Just an update, I think I have a fix for this, but just working on
> integrating it into the test suite and spending some time checking it
> against the spec.
>
> regards,
> Steve
>
> On Fri, Apr 5, 2019 at 1:47 PM Stephen Sinclair <rad...@gm...> wrote:
> >
> > Hi Steffen,
> >
> > Thanks for the bug report!
> >
> > I'll try to reproduce as soon as I get a few minutes.
> >
> > cheers,
> > Steve
> >
> >
> > On Fri, Apr 5, 2019 at 1:39 PM "Steffen Jäger" <st...@gm...> wrote:
> >>
> >> Hi everyone,
> >>
> >> first of all thank you for your very useful OSC library!
> >> Currently using Liblo 0.28.
> >> I encountered some (for me) unintended behavior in the pattern_match algorithm from (pattern_match.c) regarding curly braces (which seems to be unchanged in the relevant parts up to version 0.30).
> >> For example if I send an OSC command like
> >> /test/mute/{1,2,10,11,12} i 1
> >> with callback handlers up and ready for paths
> >> /test/mute/1
> >> /test/mute/2
> >> /test/mute/10
> >> /test/mute/11
> >> /test/mute/12
> >> I would expect all of them to be invoked.
> >> Instead only /test/mute/1, /test/mute/2, /test/mute/11, /test/mute/12 are called.
> >> The /test/mute/10 is skipped.
> >> This seems to be due to the fact that for /test/mute/10 in line 227 the statement if (c == *str) is successfully comparing c with value of '1' to '1' from "10" from str and then from here onwards something is going wrong with variable c which becomes ',' in line 241 and from here on is staying on ',' till the pattern match returns false.
> >> Same behavior seems to happen with e.g.
> >> /test/mute/{2,20}
> >> Is there something wrong with my understanding in the usage of the curly braces in OSC or is this some bug?
> >> Your help is highly appreciated.
> >>
> >> Thanks in advance!
> >>
> >> Best regards,
> >> Steffen
> >> _______________________________________________
> >> liblo-devel mailing list
> >> lib...@li...
> >> https://lists.sourceforge.net/lists/listinfo/liblo-devel