[go: up one dir, main page]

Skip to content

Fixed error when getting banned list to show in UI if bad was done from server management ui

What does this MR do and why?

Cause : Reason is empty when banning user from crafty UI

Issue: When fetching the ban list we try to get without checking

Fix: Use default reason None when fetching banlist

Traceback (most recent call last): File "/crafty/.venv/lib/python3.12/site-packages/tornado/web.py", line 1848, in _execute result = await result ^^^^^^^^^^^^ File "/crafty/app/classes/web/panel_handler.py", line 733, in get page_data["banned_players_html"] = get_banned_players_html() ^^^^^^^^^^^^^^^^^^^^^^^^^ File "/crafty/app/classes/web/panel_handler.py", line 718, in get_banned_players_html <h3>{player['name']}</h3> ~~~~~~^^^^^^^^ KeyError: 'name'

Screenshots or screen recordings

image.png

How to set up and validate locally

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

  • Have you checked this doesn't interfere/conflict/duplicate someone elses work?
  • Have you fully tested your changes?
  • Have you resolved any lint issues?
  • Have you assigned a reviewer?
  • Have you applied correct labels?
Edited by karup1

Merge request reports

Loading