[go: up one dir, main page]

Skip to content

Draft: Restore sort_value_stars_asc to options hash

What does this MR do and why?

A script identified #sort_value_stars_asc as unused, and in digging deeper, it looks an awful lot like this method, which returns a string used as a key in the hash returned by #projects_sort_options_hash, was removed by accident; indeed, there's 2 keys listed for sort_value_stars_desc, which would override the initial declaration. It looks like this change was made in the midst of a large ~"maintenance::refactor" and ~frontend transition MR so it might simply be something that was missed.

References

Screenshots or screen recordings

Before After

How to set up and validate locally

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Kerri Miller

Merge request reports

Loading