Fix duo_side_rail feature flag availability and socket cleanup
What does this MR do?
Fixes the availability of the duo_side_rail
feature flag and removes a problematic socket cleanup call in the Tanuki bot component.
Why?
The duo_side_rail
feature flag was incorrectly restricted to only show
actions via before_action only: :show
, limiting its availability. The feature flag needs to be available across all controller actions to properly enable the Duo side rail functionality throughout the application.
Additionally, the cleanupSocket()
call in the Tanuki bot's beforeDestroy
hook was causing issues when the component was destroyed.
Changes
- Remove
only: :show
restriction fromduo_side_rail
feature flag in ApplicationController - Remove
cleanupSocket()
call from Tanuki bot component'sbeforeDestroy
lifecycle hook
Screenshot
before | after |
---|---|
![]() |
![]() |
![]() |
![]() |
Related issues
https://gitlab.com/gitlab-org/gitlab/-/issues/577807+
How to set up and validate locally
- Visit home page
http://127.0.0.1:3333/
- Open the chat. You should see side-rail as well as be able to switch to agentic chat.
MR acceptance checklist
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.