liblo-devel Mailing List for LibLO

On Mon, Jan 21, 2013 at 5:41 PM, Jeremia Bär <je...@je...> wrote:
> Hi,
>
> I looked at liblo for the first time today. I had some problems getting
> the example codes to run until I realized this is because of a subtle
> difference of C and C++. In 'example_server.c', line 82
>
> lo_arg_pp(types[i], argv[i]);
>
> (where types is of 'const char*') compiles nicely as C code using gcc.
> Using the same code from C++ however, compiling with g++, yields the
> following compiling error:
>
> examples/example_server.c: In function ‘int generic_handler(const char*,
> const char*, lo_arg**, int, void*, void*)’:
> examples/example_server.c:82:36: error: invalid conversion from ‘char’
> to ‘lo_type’
> examples/example_server.c:82:36: error: initializing argument 1 of ‘void
> lo_arg_pp(lo_type, void*)’
>
> Researching I found this: In C, an enum (e.g. lo_type) is always of type
> int. Thus, an implicit type-cast is performed. In C++, enum is a
> distinct type and implicit conversion is not allowed. Making the cast
> explicit makes the code work in both C and C++, like so:
>
> lo_arg_pp((lo_type) types[i], argv[i]);
>
> Now I see that this is an example C code and maybe even a C++ programmer
> should be aware of that difference. But it's quite nasty so I'd suggest
> changing the example code to the above line or add a comment for naive
> C++ programmers like I am ;-)

Hi,

Great suggestion.  I had to think about whether it was worth changing,
but I think you're right, it's a tiny change and could resolve some
confusion for newcomers.  Committed!


> I very much like liblo. It's very straightforward.

Glad to hear it!

I can tell you that there are in fact some shiny new C++ bindings
coming down the line ;)

Steve

Hi,

I looked at liblo for the first time today. I had some problems getting 
the example codes to run until I realized this is because of a subtle 
difference of C and C++. In 'example_server.c', line 82

lo_arg_pp(types[i], argv[i]);

(where types is of 'const char*') compiles nicely as C code using gcc. 
Using the same code from C++ however, compiling with g++, yields the 
following compiling error:

examples/example_server.c: In function ‘int generic_handler(const char*, 
const char*, lo_arg**, int, void*, void*)’:
examples/example_server.c:82:36: error: invalid conversion from ‘char’ 
to ‘lo_type’
examples/example_server.c:82:36: error: initializing argument 1 of ‘void 
lo_arg_pp(lo_type, void*)’

Researching I found this: In C, an enum (e.g. lo_type) is always of type 
int. Thus, an implicit type-cast is performed. In C++, enum is a 
distinct type and implicit conversion is not allowed. Making the cast 
explicit makes the code work in both C and C++, like so:

lo_arg_pp((lo_type) types[i], argv[i]);

Now I see that this is an example C code and maybe even a C++ programmer 
should be aware of that difference. But it's quite nasty so I'd suggest 
changing the example code to the above line or add a comment for naive 
C++ programmers like I am ;-)

I very much like liblo. It's very straightforward.
Regrads,
Jeremia

Awesome, thanks Steve !!!


On 21 janv. 2013, at 16:43, Stephen Sinclair <rad...@gm...> wrote:

> Hi,
> 
> A long-awaited patch for handling buffers for open TCP streams has
> been pushed!  Previously, the TCP stream did not succeed if a whole
> message was not read in one shot, and the fix for this broke
> non-blocking behaviour.  The correct fix is to save incomplete
> messages from the stream in a buffer and append to it the next time
> recv() is called.
> 
> This is one of the last important things I wanted to take care of
> before 0.27, so please test.
> 
> I noticed that my hostname branch causes testlo to fail on Mac, so
> I'll be looking at that next.
> 
> Steve
> 
> ------------------------------------------------------------------------------
> Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
> MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
> with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
> MVPs and experts. SALE $99.99 this month only -- learn more at:
> http://p.sf.net/sfu/learnmore_122412
> _______________________________________________
> liblo-devel mailing list
> lib...@li...
> https://lists.sourceforge.net/lists/listinfo/liblo-devel

Hi,

A long-awaited patch for handling buffers for open TCP streams has
been pushed!  Previously, the TCP stream did not succeed if a whole
message was not read in one shot, and the fix for this broke
non-blocking behaviour.  The correct fix is to save incomplete
messages from the stream in a buffer and append to it the next time
recv() is called.

This is one of the last important things I wanted to take care of
before 0.27, so please test.

I noticed that my hostname branch causes testlo to fail on Mac, so
I'll be looking at that next.

Steve

On Tue, Jan 15, 2013 at 3:27 AM, Sigurd Saue <sig...@nt...> wrote:
> Yes. Building with ".\autogen.sh --disable-debug" built without errors.

Glad to hear it.  I've got a patch that fixes the warnings on MingW,
but there were a few problems with unsupported printf formatting of
64-bit numbers (e.g. "%lld") that I don't want to simply remove, so
I've got to think about how to correctly handle that.

Steve

Yes. Building with ".\autogen.sh --disable-debug" built without errors.

Thanks!
Sigurd

-----Original Message-----
From: Stephen Sinclair [mailto:rad...@gm...] 
Sent: Monday, January 14, 2013 5:52 PM
To: liblo development list
Subject: Re: [liblo] Changes in November cause MinGW problems

On Mon, Jan 14, 2013 at 10:00 AM, Sigurd Saue <sig...@nt...> wrote:
>
> Thank you for quick response. I’ve updated to latest again, but now get the following error:
>
> address.c:401:20: error: passing argument 4 of 'setsockopt' from 
> incompatible pointer type [-Werror]
>
> address.c:569:13: error: passing argument 1 of 'lstrcmpW' from 
> incompatible pointer type [-Werror]

These errors are generated by -Werror.  They should be fixed, but they should only show up if you are configured for debug mode.  Are you able to compile if you don't enable debug mode?


Steve

------------------------------------------------------------------------------
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. SALE $99.99 this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122412
_______________________________________________
liblo-devel mailing list
lib...@li...
https://lists.sourceforge.net/lists/listinfo/liblo-devel

On Mon, Jan 14, 2013 at 10:00 AM, Sigurd Saue <sig...@nt...> wrote:
>
> Thank you for quick response. I’ve updated to latest again, but now get the following error:
>
> address.c:401:20: error: passing argument 4 of 'setsockopt' from incompatible pointer type [-Werror]
>
> address.c:569:13: error: passing argument 1 of 'lstrcmpW' from incompatible pointer type [-Werror]

These errors are generated by -Werror.  They should be fixed, but they
should only show up if you are configured for debug mode.  Are you
able to compile if you don't enable debug mode?


Steve

Thank you for quick response. I’ve updated to latest again, but now get the following error:

make[3]: Entering directory `/d/Develop/liblo/src'
/bin/sh ../libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I..    -Wall -I.. -DWIN32 -D_WIN32_WINNT=0x501 -O0 -g -Wall -Werror -MT liblo_la-address.lo -MD -MP -MF .deps/liblo_la-address.Tpo -c -o liblo_la-address.lo `test -f 'address.c' || echo './'`address.c
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I.. -Wall -I.. -DWIN32 -D_WIN32_WINNT=0x501 -O0 -g -Wall -Werror -MT liblo_la-address.lo -MD -MP -MF .deps/liblo_la-address.Tpo -c address.c  -DDLL_EXPORT -DPIC -o .libs/liblo_la-address.o
address.c: In function 'lo_address_set_flags':
address.c:401:20: error: passing argument 4 of 'setsockopt' from incompatible pointer type [-Werror]
d:\develop\mingw\bin\../lib/gcc/mingw32/4.6.2/../../../../include/winsock2.h:551:32: note: expected 'const char *' but argument is of type 'int *'
address.c: In function 'lo_inaddr_find_iface':
address.c:569:13: error: passing argument 1 of 'lstrcmpW' from incompatible pointer type [-Werror]
d:\develop\mingw\bin\../lib/gcc/mingw32/4.6.2/../../../../include/winbase.h:1929:23: note: expected 'LPCWSTR' but argument is of type 'const char *'
cc1.exe: all warnings being treated as errors

make[3]: *** [liblo_la-address.lo] Error 1
make[3]: Leaving directory `/d/Develop/liblo/src'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/d/Develop/liblo/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/d/Develop/liblo'
make: *** [all] Error 2

From: Stephen Sinclair [mailto:rad...@gm...]
Sent: Monday, January 14, 2013 3:39 PM
To: liblo development list
Subject: Re: [liblo] Changes in November cause MinGW problems

On Mon, Jan 14, 2013 at 9:23 AM, Sigurd Saue <sig...@nt...<mailto:sig...@nt...>> wrote:
Hi,

I tried to build liblo from the latest GIT, but it failed due to "netinet/tcp.h" not found (in address.c). I build on Windows 7 using MinGW, and the sys/netinet files are not present there.  This dependency was introduced into liblo 2012-09-03. When I reverted to an earlier commit, liblo built fine.

Is there a way to remove this dependency on Windows again (e.g. by checking WIN32)?

Hello,

Yes, I just pushed a patch to fix this as well as add a couple of missing functions to the .def file.

I compiled with MingW without errors, let me know how it goes.

Steve

On Mon, Jan 14, 2013 at 9:23 AM, Sigurd Saue <sig...@nt...> wrote:

> Hi,
>
> I tried to build liblo from the latest GIT, but it failed due to
> "netinet/tcp.h" not found (in address.c). I build on Windows 7 using MinGW,
> and the sys/netinet files are not present there.  This dependency was
> introduced into liblo 2012-09-03. When I reverted to an earlier commit,
> liblo built fine.
>
> Is there a way to remove this dependency on Windows again (e.g. by
> checking WIN32)?
>
>
Hello,

Yes, I just pushed a patch to fix this as well as add a couple of missing
functions to the .def file.

I compiled with MingW without errors, let me know how it goes.

Steve

Hi,

I tried to build liblo from the latest GIT, but it failed due to "netinet/tcp.h" not found (in address.c). I build on Windows 7 using MinGW, and the sys/netinet files are not present there.  This dependency was introduced into liblo 2012-09-03. When I reverted to an earlier commit, liblo built fine.

Is there a way to remove this dependency on Windows again (e.g. by checking WIN32)?

Sigurd